diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/domain/vdmn/utils/VDmnFunctions.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/domain/vdmn/utils/VDmnFunctions.java index 8ce99e980b5f15ed14ba1d0f36ee0b078adbb108..4c504b213a3cc6240488e210727c28f2abd4eb66 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/domain/vdmn/utils/VDmnFunctions.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/domain/vdmn/utils/VDmnFunctions.java @@ -161,11 +161,11 @@ public class VDmnFunctions { return true; } for (int i = 0; i < oneRule.getDmnOutputValues().size(); i++) { - if (oneRule + if (!oneRule .getDmnOutputValues() .get(i) .getText() - .equals(otherRule.getDmnOutputValues().get(0).getText())) { + .equals(otherRule.getDmnOutputValues().get(i).getText())) { return true; } } diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/PartialReductionVerifier.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/PartialReductionVerifier.java index f95267dfd25e4ca1dd43d73f51cf53d48d8b6803..38aca480857e44095531b9f35087c071b6c960ea 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/PartialReductionVerifier.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/PartialReductionVerifier.java @@ -32,8 +32,7 @@ public class PartialReductionVerifier extends AbstractVerifier { List<List<VDmnRule>> identicalOutputCluster = VDmnFunctions.getRuleClustersWithIdenticalOutput(dmnDecisionTable); List<VDmnInputColumn> inColumns = dmnDecisionTable.getInputColumns(); - identicalOutputCluster.stream() // do: parallelStream() ? - .forEach(c -> findPartialReduction(inColumns, 0, c, false)); + identicalOutputCluster.forEach(c -> findPartialReduction(inColumns, 0, c, false)); } private void findPartialReduction( @@ -46,7 +45,7 @@ public class PartialReductionVerifier extends AbstractVerifier { VerificationResultEntryElement.create(inColumns.get(0).getDmnDecisionTable()) .withIdentifier(rule.getRuleId()))); vreFactory.addVerificationFix(SHOW_RULES); - vreFactory.addToEntry(VerificationClassification.WARNING, "PartialReduction"); + vreFactory.addToEntry(VerificationClassification.INFO, "PartialReduction"); } } else { List<VDmnInputValue> rules =