From 19a8184aae0c53566b81731bcb30686ea8293123 Mon Sep 17 00:00:00 2001
From: Jonas Blatt <jonasblatt@uni-koblenz.de>
Date: Mon, 14 Oct 2019 19:57:03 +0200
Subject: [PATCH] Fix PartialReductionVerifier
---
.../fgbks/core/dmn/domain/vdmn/utils/VDmnFunctions.java | 4 ++--
.../verification/verifier/impl/PartialReductionVerifier.java | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/domain/vdmn/utils/VDmnFunctions.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/domain/vdmn/utils/VDmnFunctions.java
index 8ce99e98..4c504b21 100644
--- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/domain/vdmn/utils/VDmnFunctions.java
+++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/domain/vdmn/utils/VDmnFunctions.java
@@ -161,11 +161,11 @@ public class VDmnFunctions {
return true;
}
for (int i = 0; i < oneRule.getDmnOutputValues().size(); i++) {
- if (oneRule
+ if (!oneRule
.getDmnOutputValues()
.get(i)
.getText()
- .equals(otherRule.getDmnOutputValues().get(0).getText())) {
+ .equals(otherRule.getDmnOutputValues().get(i).getText())) {
return true;
}
}
diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/PartialReductionVerifier.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/PartialReductionVerifier.java
index f95267df..38aca480 100644
--- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/PartialReductionVerifier.java
+++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/PartialReductionVerifier.java
@@ -32,8 +32,7 @@ public class PartialReductionVerifier extends AbstractVerifier {
List<List<VDmnRule>> identicalOutputCluster =
VDmnFunctions.getRuleClustersWithIdenticalOutput(dmnDecisionTable);
List<VDmnInputColumn> inColumns = dmnDecisionTable.getInputColumns();
- identicalOutputCluster.stream() // do: parallelStream() ?
- .forEach(c -> findPartialReduction(inColumns, 0, c, false));
+ identicalOutputCluster.forEach(c -> findPartialReduction(inColumns, 0, c, false));
}
private void findPartialReduction(
@@ -46,7 +45,7 @@ public class PartialReductionVerifier extends AbstractVerifier {
VerificationResultEntryElement.create(inColumns.get(0).getDmnDecisionTable())
.withIdentifier(rule.getRuleId())));
vreFactory.addVerificationFix(SHOW_RULES);
- vreFactory.addToEntry(VerificationClassification.WARNING, "PartialReduction");
+ vreFactory.addToEntry(VerificationClassification.INFO, "PartialReduction");
}
} else {
List<VDmnInputValue> rules =
--
GitLab