From 5132096f3d1f06ea03b14c91ef0d85e4ae3f6064 Mon Sep 17 00:00:00 2001
From: Jonas Blatt <jonasblatt@uni-koblenz.de>
Date: Sat, 19 Oct 2019 21:45:37 +0200
Subject: [PATCH] bugfix missing Rules, (TODO ID was not unique)
---
.../verification/verifier/impl/MissingRuleVerifier.java | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/MissingRuleVerifier.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/MissingRuleVerifier.java
index 0b0d4eaf..25588d97 100644
--- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/MissingRuleVerifier.java
+++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/MissingRuleVerifier.java
@@ -2,6 +2,7 @@ package de.unikoblenz.fgbks.core.dmn.verification.verifier.impl;
import static de.unikoblenz.fgbks.core.dmn.domain.vdmn.utils.VDmnFunctions.templateDecision;
+import de.unikoblenz.fgbks.base.utils.UniqueIdGenerator;
import de.unikoblenz.fgbks.base.utils.boundary.Boundary;
import de.unikoblenz.fgbks.base.utils.boundary.bicreater.BoundaryBiCreaterType;
import de.unikoblenz.fgbks.base.utils.boundary.checker.BoundaryCheckType;
@@ -155,7 +156,8 @@ public class MissingRuleVerifier extends AbstractVerifier {
missingRule.setInputValue(
i - 1,
VDmnInputValueImpl.getBuilder()
- .withInputEntryId(new InputEntryId("TODO")) // TODO
+ .withInputEntryId(
+ new InputEntryId("Entry_" + Long.toString(UniqueIdGenerator.getNextId(), 16)))
.withText("")
.withDmnInputColumn((VDmnInputColumn) missingRuleValue.getDmnColumn())
.withDmnRule(missingRule)
@@ -201,7 +203,7 @@ public class MissingRuleVerifier extends AbstractVerifier {
Builder b =
VDmnRuleImpl.getBuilder()
- .withRuleId(new RuleId("TODO")) // TODO
+ .withRuleId(new RuleId("Rule_" + Long.toString(UniqueIdGenerator.getNextId(), 16)))
.withDmnDecisionTable(inputs.get(0).getDmnDecisionTable())
.withRowNumber(new RowNumber(INITIAL_ROW_NUMER));
for (VDmnInputValue inputValue : missingRuleValues) {
@@ -214,7 +216,8 @@ public class MissingRuleVerifier extends AbstractVerifier {
copy.setInputValue(
x,
VDmnInputValueImpl.getBuilder()
- .withInputEntryId(new InputEntryId("TODO")) // TODO
+ .withInputEntryId(
+ new InputEntryId("Entry_" + Long.toString(UniqueIdGenerator.getNextId(), 16)))
.withText("")
.withDmnRule(copy)
.withBoundary(x == i ? bi.get() : missingRuleValues.get(x).getBoundary())
--
GitLab