From 923ae328c22ff7ee3c7fbf3553499f4a9578478d Mon Sep 17 00:00:00 2001 From: Jonas Blatt <jonasblatt@uni-koblenz.de> Date: Sun, 8 Sep 2019 20:26:41 +0200 Subject: [PATCH] Formatting --- .../fgbks/api/test/GreetingResource.java | 3 +-- .../de/unikoblenz/fgbks/api/test/TestApi.java | 2 -- .../fgbks/base/utils/UniqueIdGenerator.java | 3 +-- .../verfication/VerificationGenerator.java | 23 +++++++++---------- .../VerificationTypeClassification.java | 8 ++++--- .../result/VerificationResultEntry.java | 5 +++- .../VerificationResultEntryElement.java | 9 +++++--- .../VerificationResultEntryFactory.java | 7 +++--- .../verfication/result/VerifierResult.java | 4 ++-- .../verifier/AbstractVerifier.java | 2 -- .../verfication/verifier/SampleVerifier.java | 19 +++++++-------- .../dmn/verfication/verifier/Verifier.java | 1 - 12 files changed, 44 insertions(+), 42 deletions(-) diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/api/test/GreetingResource.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/api/test/GreetingResource.java index a5d95fef..1a16a2bb 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/api/test/GreetingResource.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/api/test/GreetingResource.java @@ -20,8 +20,7 @@ public class GreetingResource { private static Logger LOGGER = LoggerFactory.getLogger("test"); - @Inject - WordnetServiceX wordnetServiceX; + @Inject WordnetServiceX wordnetServiceX; @ConfigProperty(name = "hello") private String greet; diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/api/test/TestApi.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/api/test/TestApi.java index a5964c64..da063f0e 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/api/test/TestApi.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/api/test/TestApi.java @@ -6,14 +6,12 @@ import javax.ws.rs.Path; import javax.ws.rs.Produces; import javax.ws.rs.core.MediaType; import javax.ws.rs.core.Response; -import org.eclipse.microprofile.config.inject.ConfigProperty; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @Path("/builder") public class TestApi { - private static Logger LOGGER = LoggerFactory.getLogger(TestApi.class.getSimpleName()); @GET diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/base/utils/UniqueIdGenerator.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/base/utils/UniqueIdGenerator.java index 67682521..58fb304e 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/base/utils/UniqueIdGenerator.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/base/utils/UniqueIdGenerator.java @@ -4,8 +4,7 @@ public class UniqueIdGenerator { private static volatile long id = 0; - private UniqueIdGenerator() { - } + private UniqueIdGenerator() {} public static synchronized long getNextId() { return id++; diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/VerificationGenerator.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/VerificationGenerator.java index 8ece6ef8..e85edb31 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/VerificationGenerator.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/VerificationGenerator.java @@ -18,9 +18,7 @@ public class VerificationGenerator { public static VerifierResultSet generate() { Config config = ConfigProvider.getConfig(); - Integer maxThreads = config - .getOptionalValue(CONF_VERIFIER_THREADS, Integer.class) - .orElse(1); + Integer maxThreads = config.getOptionalValue(CONF_VERIFIER_THREADS, Integer.class).orElse(1); ExecutorService executor = Executors.newFixedThreadPool(maxThreads); @@ -32,15 +30,16 @@ public class VerificationGenerator { results.add(vType.createNewInstance().verify(executor)); } - results.forEach(r -> { - try { - resultBuilder.addVerifierResult(r.get()); - } catch (InterruptedException e) { - e.printStackTrace(); - } catch (ExecutionException e) { - e.printStackTrace(); - } - }); + results.forEach( + r -> { + try { + resultBuilder.addVerifierResult(r.get()); + } catch (InterruptedException e) { + e.printStackTrace(); + } catch (ExecutionException e) { + e.printStackTrace(); + } + }); return resultBuilder.build(); } diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/VerificationTypeClassification.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/VerificationTypeClassification.java index c2c5874a..7eaf523f 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/VerificationTypeClassification.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/VerificationTypeClassification.java @@ -6,7 +6,9 @@ import java.util.HashSet; import java.util.Set; public enum VerificationTypeClassification implements Serializable { - DECISION_LOGIC_LEVEL_VERIFICATION("Decision Logic Verification", "", + DECISION_LOGIC_LEVEL_VERIFICATION( + "Decision Logic Verification", + "", new HashSet<>(Arrays.asList(VerificationType.IDENTICAL_BUSINESS_RULE_VERIFICATION))); private String name; @@ -25,8 +27,8 @@ public enum VerificationTypeClassification implements Serializable { return new HashSet<>(verificationTypes); } - VerificationTypeClassification(String name, String description, - Set<VerificationType> verificationTypes) { + VerificationTypeClassification( + String name, String description, Set<VerificationType> verificationTypes) { this.name = name; this.description = description; this.verificationTypes = verificationTypes; diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerificationResultEntry.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerificationResultEntry.java index 053a097a..287e719b 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerificationResultEntry.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerificationResultEntry.java @@ -10,7 +10,10 @@ import org.apache.commons.lang3.Validate; public class VerificationResultEntry extends AbstractResultObject { public enum VerificationClassification { - INFO, WARNING, ERROR, FATAL_ERROR; + INFO, + WARNING, + ERROR, + FATAL_ERROR; } private Set<VerificationResultEntryElement> verificationResultEntryElements; diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerificationResultEntryElement.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerificationResultEntryElement.java index fa306010..63e7360e 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerificationResultEntryElement.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerificationResultEntryElement.java @@ -66,9 +66,12 @@ public class VerificationResultEntryElement extends AbstractResultObject { private VerificationResultEntryElement withProperty(String key, String value) { // every properties can only be set once - Validate - .isTrue(!properties.containsKey(key), "Property %s with value %s in %s already set", key, - value, VerificationResultEntryElement.class.getSimpleName()); + Validate.isTrue( + !properties.containsKey(key), + "Property %s with value %s in %s already set", + key, + value, + VerificationResultEntryElement.class.getSimpleName()); properties.put(key, value); return this; } diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerificationResultEntryFactory.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerificationResultEntryFactory.java index 4c6b4713..5a57a753 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerificationResultEntryFactory.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerificationResultEntryFactory.java @@ -35,9 +35,10 @@ public class VerificationResultEntryFactory { addToEntry(verificationClassification, message, null); } - public void addToEntry(VerificationClassification verificationClassification, String message, - Object... args) { - Validate.notNull(verificationResultEntryBuilder, + public void addToEntry( + VerificationClassification verificationClassification, String message, Object... args) { + Validate.notNull( + verificationResultEntryBuilder, "First call \"addElement\" in VerificationResultEntryFactory before calling \"addToEntry\""); verificationResultEntryBuilder.withClassification(verificationClassification); verificationResultEntryBuilder.withMessage(String.format(Validate.notNull(message), args)); diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerifierResult.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerifierResult.java index e69c55e6..61fc946d 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerifierResult.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/result/VerifierResult.java @@ -29,12 +29,12 @@ public class VerifierResult extends AbstractResultObject { } @JsonbProperty("type_description") - public String getVerificationTypeDescription(){ + public String getVerificationTypeDescription() { return verificationType.getDescription(); } @JsonbProperty("type_classification") - public String getVerificationTypeClassification(){ + public String getVerificationTypeClassification() { return verificationType.getClassification().getName(); } diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/verifier/AbstractVerifier.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/verifier/AbstractVerifier.java index deb2c19f..f88b1d2e 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/verifier/AbstractVerifier.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/verifier/AbstractVerifier.java @@ -4,9 +4,7 @@ import de.unikoblenz.fgbks.core.dmn.verfication.VerificationType; import de.unikoblenz.fgbks.core.dmn.verfication.result.VerificationResultEntryFactory; import de.unikoblenz.fgbks.core.dmn.verfication.result.VerifierResult; import java.util.Objects; -import java.util.Set; import java.util.concurrent.Callable; -import java.util.concurrent.Executor; import java.util.concurrent.ExecutorService; import java.util.concurrent.Future; diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/verifier/SampleVerifier.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/verifier/SampleVerifier.java index 0a5de313..6e202dd3 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/verifier/SampleVerifier.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/verifier/SampleVerifier.java @@ -13,20 +13,21 @@ public class SampleVerifier extends AbstractVerifier { @Override protected void doVerification() { - vref.addElement(VerificationResultEntryElement.create() - .withDecisionId("hello workd") - .withInputEntryId("adsas") - .withRuleId("asdads")); - vref.addElement(VerificationResultEntryElement.create() - .withDecisionId("hello workd") - .withInputEntryId("adsas") - .withRuleId("asdads")); + vref.addElement( + VerificationResultEntryElement.create() + .withDecisionId("hello workd") + .withInputEntryId("adsas") + .withRuleId("asdads")); + vref.addElement( + VerificationResultEntryElement.create() + .withDecisionId("hello workd") + .withInputEntryId("adsas") + .withRuleId("asdads")); vref.addToEntry(ERROR, "Asd"); try { Thread.sleep(1500); } catch (InterruptedException e) { e.printStackTrace(); } - } } diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/verifier/Verifier.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/verifier/Verifier.java index 279ad8ac..dbc438c8 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/verifier/Verifier.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verfication/verifier/Verifier.java @@ -1,7 +1,6 @@ package de.unikoblenz.fgbks.core.dmn.verfication.verifier; import de.unikoblenz.fgbks.core.dmn.verfication.result.VerifierResult; -import java.util.Set; import java.util.concurrent.ExecutorService; import java.util.concurrent.Future; -- GitLab