diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/MissingRuleVerifier.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/MissingRuleVerifier.java index 0e6bdcd2695d031cabcd7a3bb7c7e6a4966e47d9..6f72e8e924b56d3d239fdfa7f47fb5a62f608788 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/MissingRuleVerifier.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/MissingRuleVerifier.java @@ -65,7 +65,10 @@ public class MissingRuleVerifier extends AbstractVerifier { .collect(Collectors.joining(" / "))); sb.append(" }"); Action.Builder fixActionBuilder = - Action.getBuilder().withActionScope(ActionScope.RULE).withActionType(ActionType.CREATE); + Action.getBuilder() + .withActionScope(ActionScope.RULE) + .withActionType(ActionType.CREATE) + .addValue("decisionId", missingRule.getVDmnDecision().getDecisionId().getValue()); for (VDmnInputValue v : missingRule.getVDmnInputValues()) { fixActionBuilder.addValue( v.getVDmnInputColumn().getInputId().getValue(), v.getBoundary().getParsedText()); @@ -99,14 +102,14 @@ public class MissingRuleVerifier extends AbstractVerifier { private VDmnRuleChangeableImpl constructPseudoMissingRule(List<VDmnInputColumn> inputs) { Builder b = VDmnRuleImpl.getBuilder() - .withRuleId(new RuleId("TODO")) // TODO + .withRuleId(new RuleId("TODO")) .withVDmnDecisionTable(inputs.get(0).getVDmnDecisionTable()) .withRowNumber(new RowNumber(INITIAL_ROW_NUMER)); for (VDmnInputColumn col : inputs) { b.addVDmnInputValue( VDmnInputValueImpl.getBuilder() - .withInputEntryId(new InputEntryId("TODO")) // TODO + .withInputEntryId(new InputEntryId("TODO")) .withText("") .withVDmnInputColumn(col) .withVDmnRuleFromBuilder(b) diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/PartialReductionVerifier.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/PartialReductionVerifier.java index 2c9c58eef3281a5f23ae980f54b034995d281d80..a166b441b3888f56d4a7d89f954ce1223798034b 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/PartialReductionVerifier.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/PartialReductionVerifier.java @@ -157,7 +157,10 @@ public class PartialReductionVerifier extends AbstractVerifier { .get()); } Action.Builder fixActionBuilder = - Action.getBuilder().withActionScope(ActionScope.RULE).withActionType(ActionType.CREATE); + Action.getBuilder() + .withActionScope(ActionScope.RULE) + .withActionType(ActionType.CREATE) + .addValue("decisionId", inColumns.get(0).getVDmnDecision().getDecisionId().getValue()); for (int i = 0; i < inColumns.size(); i++) { fixActionBuilder.addValue( inColumns.get(i).getInputId().getValue(), boundaries.get(i).getParsedText()); diff --git a/dmnverifierfrontend/src/main/resources/META-INF/resources/js/dmnVerifierActions.js b/dmnverifierfrontend/src/main/resources/META-INF/resources/js/dmnVerifierActions.js index b2b0570f72c073f4bcfb83a763e190d40ede8e95..93879338e20c79918c31a9261c4f2ca90fb71025 100644 --- a/dmnverifierfrontend/src/main/resources/META-INF/resources/js/dmnVerifierActions.js +++ b/dmnverifierfrontend/src/main/resources/META-INF/resources/js/dmnVerifierActions.js @@ -214,7 +214,7 @@ function performVerificationFixCREATE(verificationEntry, fixAction) { * @param {Action} fixAction */ function createRule(verificationEntry, fixAction) { - openViewWithId(verificationEntry.elements[0].identifier['decisionId']); + openViewWithId(fixAction.actionValues['decisionId']); const modeler = getCurrentModeler(); const rule = modeler.addRow({type: "dmn:DecisionRule"}); const {cells} = rule; @@ -298,7 +298,7 @@ function performVerificationFixDELETE(verificationEntry, fixAction) { * @param {Action} fixAction */ function deleteRule(verificationEntry, fixAction) { - openViewWithId(verificationEntry.elements[0].identifier['decisionId']); + openViewWithId(fixAction.actionValues['decisionId']); const modeler = getCurrentModeler(); for (const [key, value] of Object.entries(fixAction.actionValues)) { if (key === 'ruleId') { @@ -314,7 +314,7 @@ function deleteRule(verificationEntry, fixAction) { * @param {String} columnIdName */ function deleteColumn(verificationEntry, fixAction, columnIdName) { - openViewWithId(verificationEntry.elements[0].identifier['decisionId']); + openViewWithId(fixAction.actionValues['decisionId']); const modeler = getCurrentModeler(); verificationEntry.elements.forEach(function (el) { let col = getSheetElementWithId(el.identifier[columnIdName]);