From d007b3b6b2de5ed34375948cab682f8e4ddf1cb1 Mon Sep 17 00:00:00 2001
From: Jonas Blatt <jonasblatt@uni-koblenz.de>
Date: Thu, 17 Oct 2019 20:10:37 +0200
Subject: [PATCH] #2 Optimize Message Text Missing Rule Verification
---
.../verification/verifier/impl/MissingRuleVerifier.java | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/MissingRuleVerifier.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/MissingRuleVerifier.java
index 3dbce41a..0b0d4eaf 100644
--- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/MissingRuleVerifier.java
+++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/MissingRuleVerifier.java
@@ -49,12 +49,13 @@ public class MissingRuleVerifier extends AbstractVerifier {
for (VDmnRule missingRule : missingRules) {
StringBuilder sb = new StringBuilder();
sb.append(templateDecision(dmnDecisionTable.getDmnDecision()));
- sb.append("The following rule is not defined: {");
+ sb.append("The following rule is not defined: { ");
sb.append(
missingRule.getDmnInputValues().stream()
.map(v -> v.getBoundary().getParsedText())
- .collect(Collectors.joining("), (")));
- sb.append("}");
+ .map(s -> s.isEmpty() ? "-" : s)
+ .collect(Collectors.joining(" / ")));
+ sb.append(" }");
vreFactory.addElement(VerificationResultEntryElement.create(dmnDecisionTable));
vreFactory.addToEntry(VerificationClassification.WARNING, sb.toString());
--
GitLab