diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/result/VerificationResultEntry.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/result/VerificationResultEntry.java index 7c33e5a21efde05b66bd3a57a3ff2ba047c08fe3..214a8a08d473c59a22edb93f09254e281d26977b 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/result/VerificationResultEntry.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/result/VerificationResultEntry.java @@ -2,8 +2,8 @@ package de.unikoblenz.fgbks.core.dmn.verification.result; import de.unikoblenz.fgbks.base.builder.DefaultBuilder; import de.unikoblenz.fgbks.base.domain.Message; -import de.unikoblenz.fgbks.core.dmn.verification.verifier.Verifier; import de.unikoblenz.fgbks.core.dmn.verification.result.actions.VerificationFix; +import de.unikoblenz.fgbks.core.dmn.verification.verifier.Verifier; import java.util.ArrayList; import java.util.Collections; import java.util.HashSet; @@ -22,17 +22,13 @@ import org.apache.commons.lang3.Validate; public class VerificationResultEntry extends AbstractResultObject { /** - * Enum to classify one {@link VerificationResultEntry}. + * Get the list of {@link VerificationFix}es. + * + * @return the list of {@link VerificationFix}es */ - public enum VerificationClassification { - /** Only information. */ - INFO, - /** Warning. No action needed. */ - WARNING, - /** Error. Action needed. */ - ERROR, - /** Fatal error. Must be fixed, so that the dmn is executable. */ - FATAL_ERROR + @JsonbProperty("verificationFixes") + public List<VerificationFix> getVerificationsFixes() { + return Collections.unmodifiableList(verificationFixes); } private List<VerificationFix> verificationFixes; @@ -45,9 +41,18 @@ public class VerificationResultEntry extends AbstractResultObject { verificationFixes = new ArrayList<>(); } - @JsonbProperty("verificationFixes") - public List<VerificationFix> getVerificationsFixes() { - return Collections.unmodifiableList(verificationFixes); + /** + * Enum to classify one {@link VerificationResultEntry}. + */ + public enum VerificationClassification { + /** Only information. */ + INFO, + /** Warning. No action needed. */ + WARNING, + /** Error. Action needed. */ + ERROR, + /** Fatal error. Must be fixed, so that the dmn is executable. */ + FATAL_ERROR } /** @@ -90,11 +95,6 @@ public class VerificationResultEntry extends AbstractResultObject { return new Message(message); } - private void addVerificationResultEntry( - VerificationResultEntryElement verificationResultEntryElement) { - this.verificationResultEntryElements.add(verificationResultEntryElement); - } - /** * Get a new instance of a {@link Builder} for a {@link VerificationResultEntry}. * @@ -115,7 +115,7 @@ public class VerificationResultEntry extends AbstractResultObject { */ public Builder addVerificationResultEntryElement( VerificationResultEntryElement verificationResultEntryElement) { - value.addVerificationResultEntry(Validate.notNull(verificationResultEntryElement)); + value.verificationResultEntryElements.add(Validate.notNull(verificationResultEntryElement)); return this; } @@ -141,6 +141,12 @@ public class VerificationResultEntry extends AbstractResultObject { return this; } + /** + * Add a {@link VerificationFix} to the {@link VerificationResultEntry}. + * + * @param verificationFix the {@link VerificationFix} + * @return the current builder + */ public Builder addVerificationFix(VerificationFix verificationFix) { value.verificationFixes.add(Validate.notNull(verificationFix)); return this; diff --git a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/result/VerificationResultEntryFactory.java b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/result/VerificationResultEntryFactory.java index 8a933dcb1d4e91128d2fbe57d9e5f9d150bbd82d..57456ca2ed1d85392ca2aacaaa21b4f99532890d 100644 --- a/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/result/VerificationResultEntryFactory.java +++ b/dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/result/VerificationResultEntryFactory.java @@ -11,8 +11,8 @@ import org.apache.commons.lang3.Validate; * VerificationResultEntryFactory#create(Builder)} with and instance of the {@link * VerifierResult.Builder}. Than, for each new result for one verifier first call {@link * VerificationResultEntryFactory#addElement(VerificationResultEntryElement)} for every element you - * want to add. Finally call {@link VerificationResultEntryFactory#addToEntry(VerificationClassification, - * String)} to add the result. + * want to add. Finally call {@link + * VerificationResultEntryFactory#addToEntry(VerificationClassification, String)} to add the result. */ public class VerificationResultEntryFactory { @@ -41,6 +41,12 @@ public class VerificationResultEntryFactory { return verificationResultEntryBuilder; } + /** + * Add a new {@link VerificationFix} to the {@link VerificationResultEntry}. + * + * @param verificationFix the {@link VerificationFix} + * @return the current {@link VerificationResultEntryFactory} + */ public VerificationResultEntryFactory addVerificationFix(VerificationFix verificationFix) { getCurrentOrCreate().addVerificationFix(verificationFix); return this;