From 18f09bac612896609c90fc871803693db0cfad91 Mon Sep 17 00:00:00 2001
From: Alexander Gauggel <agauggel@uni-koblenz.de>
Date: Thu, 24 Jun 2021 02:05:18 +0200
Subject: [PATCH] [#82] Shadows adjustments?

---
 projects/voxelization/resources/shaders/shader.frag       | 2 +-
 projects/voxelization/resources/shaders/shadowMapping.inc | 2 +-
 projects/voxelization/src/ShadowMapping.cpp               | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/projects/voxelization/resources/shaders/shader.frag b/projects/voxelization/resources/shaders/shader.frag
index eff75dde..2b356691 100644
--- a/projects/voxelization/resources/shaders/shader.frag
+++ b/projects/voxelization/resources/shaders/shader.frag
@@ -87,7 +87,7 @@ void main()	{
     vec3 sun        = lightInfo.sunStrength * lightInfo.sunColor * NoL;
     
     float   noise           = 2 * pi * interleavedGradientNoise(gl_FragCoord.xy);
-    vec2    shadowOffset    = vec2(sin(noise), cos(noise)) * 0.00008;
+    vec2    shadowOffset    = 0.05f * vec2(sin(noise), cos(noise)) / textureSize(sampler2D(shadowMap, shadowMapSampler), 0);
     float   shadow          = shadowTest(passPos, lightInfo, shadowMap, shadowMapSampler, shadowOffset);
     sun                     *= shadow;
     
diff --git a/projects/voxelization/resources/shaders/shadowMapping.inc b/projects/voxelization/resources/shaders/shadowMapping.inc
index 8f14d35d..4755e7ec 100644
--- a/projects/voxelization/resources/shaders/shadowMapping.inc
+++ b/projects/voxelization/resources/shaders/shadowMapping.inc
@@ -86,7 +86,7 @@ float shadowTest(vec3 worldPos, LightInfo lightInfo, texture2D shadowMap, sample
     shadowMapSample = unquantizeMoments(shadowMapSample);
     
     float depthBias     = 0.f;
-    float momentBias    = 0.00005;
+    float momentBias    = 0.000002;
     
     float shadow = ComputeMSMShadowIntensity(shadowMapSample, lightPos.z, depthBias, momentBias);
     return reduceLightBleeding(shadow, 0.1f);
diff --git a/projects/voxelization/src/ShadowMapping.cpp b/projects/voxelization/src/ShadowMapping.cpp
index 3c2beb5f..e27895ae 100644
--- a/projects/voxelization/src/ShadowMapping.cpp
+++ b/projects/voxelization/src/ShadowMapping.cpp
@@ -125,7 +125,7 @@ glm::mat4 computeShadowViewProjectionMatrix(
 
 const vk::Format            shadowMapFormat         = vk::Format::eR32G32B32A32Sfloat;
 const vk::Format            shadowMapDepthFormat    = vk::Format::eD32Sfloat;
-const uint32_t              shadowMapResolution     = 1024;
+const uint32_t              shadowMapResolution     = 2048;
 const vkcv::Multisampling   msaa                    = vkcv::Multisampling::MSAA8X;
 
 ShadowMapping::ShadowMapping(vkcv::Core* corePtr, const vkcv::VertexLayout& vertexLayout) : 
@@ -156,7 +156,7 @@ ShadowMapping::ShadowMapping(vkcv::Core* corePtr, const vkcv::VertexLayout& vert
 	};
 	shadowPipeConfig.m_multisampling        = msaa;
 	shadowPipeConfig.m_EnableDepthClamping  = true;
-    shadowPipeConfig.m_culling              = vkcv::CullMode::Front;
+	shadowPipeConfig.m_culling              = vkcv::CullMode::Front;
 	m_shadowMapPipe                         = corePtr->createGraphicsPipeline(shadowPipeConfig);
 
 	m_shadowSampler = corePtr->createSampler(
-- 
GitLab