From 28fb98d19a73fa7ac65760bdbd01686037f648f9 Mon Sep 17 00:00:00 2001 From: Tobias Frisch <tfrisch@uni-koblenz.de> Date: Sat, 12 Jun 2021 23:12:51 +0200 Subject: [PATCH] [#73] Added todo mark and fixed a warning Signed-off-by: Tobias Frisch <tfrisch@uni-koblenz.de> --- modules/shader_compiler/src/vkcv/shader/GLSLCompiler.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/modules/shader_compiler/src/vkcv/shader/GLSLCompiler.cpp b/modules/shader_compiler/src/vkcv/shader/GLSLCompiler.cpp index 4fcddb31..a15009b8 100644 --- a/modules/shader_compiler/src/vkcv/shader/GLSLCompiler.cpp +++ b/modules/shader_compiler/src/vkcv/shader/GLSLCompiler.cpp @@ -184,7 +184,9 @@ namespace vkcv::shader { return false; } - std::streamsize fileSize = static_cast<std::streamsize>(spirv.size()) * sizeof(uint32_t); + const auto fileSize = static_cast<std::streamsize>( + sizeof(uint32_t) * spirv.size() + ); file.seekp(0); file.write(reinterpret_cast<const char*>(spirv.data()), fileSize); @@ -256,6 +258,10 @@ namespace vkcv::shader { } std::filesystem::remove(tmp_path); + + if (update) { + // TODO: Shader hot compilation during runtime + } } } -- GitLab