From 42bfeee62525150c8ddcb6124de87bc28150c998 Mon Sep 17 00:00:00 2001
From: Tobias Frisch <tfrisch@uni-koblenz.de>
Date: Sat, 17 Sep 2022 22:41:13 +0200
Subject: [PATCH] Removed include and fixed parameter type
Signed-off-by: Tobias Frisch <tfrisch@uni-koblenz.de>
---
include/vkcv/Pass.hpp | 2 +-
projects/first_triangle/src/main.cpp | 1 -
src/vkcv/Pass.cpp | 6 +++---
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/include/vkcv/Pass.hpp b/include/vkcv/Pass.hpp
index f6f7e32c..0bbb8194 100644
--- a/include/vkcv/Pass.hpp
+++ b/include/vkcv/Pass.hpp
@@ -11,7 +11,7 @@
namespace vkcv {
- PassHandle passFormats(Core &core, const std::vector<vk::Format> formats, bool clear = true,
+ PassHandle passFormats(Core &core, const std::vector<vk::Format> &formats, bool clear = true,
Multisampling multisampling = Multisampling::None);
PassHandle passFormat(Core &core, vk::Format format, bool clear = true,
diff --git a/projects/first_triangle/src/main.cpp b/projects/first_triangle/src/main.cpp
index 7d985e21..5d249d04 100644
--- a/projects/first_triangle/src/main.cpp
+++ b/projects/first_triangle/src/main.cpp
@@ -1,5 +1,4 @@
#include <iostream>
-#include <vkcv/Buffer.hpp>
#include <vkcv/Core.hpp>
#include <vkcv/Pass.hpp>
#include <GLFW/glfw3.h>
diff --git a/src/vkcv/Pass.cpp b/src/vkcv/Pass.cpp
index 0aaaa4a9..147d7151 100644
--- a/src/vkcv/Pass.cpp
+++ b/src/vkcv/Pass.cpp
@@ -3,7 +3,7 @@
namespace vkcv {
- PassHandle passFormats(Core &core, const std::vector<vk::Format> formats, bool clear,
+ PassHandle passFormats(Core &core, const std::vector<vk::Format> &formats, bool clear,
Multisampling multisampling) {
AttachmentDescriptions attachments;
@@ -22,9 +22,9 @@ namespace vkcv {
}
PassHandle passSwapchain(Core &core, const SwapchainHandle &swapchain,
- const std::vector<vk::Format> formats, bool clear,
+ const std::vector<vk::Format> &formats, bool clear,
Multisampling multisampling) {
- std::vector<vk::Format> swapchainFormats(formats);
+ std::vector<vk::Format> swapchainFormats (formats);
for (auto &format : swapchainFormats) {
if (vk::Format::eUndefined == format) {
--
GitLab