diff --git a/config/lib/GLFW.cmake b/config/lib/GLFW.cmake index 1b68d8aa97ba59158a7bd805ab2470f554f705aa..d7c9dedc8e9bd873c2d654923022dba446836e23 100644 --- a/config/lib/GLFW.cmake +++ b/config/lib/GLFW.cmake @@ -1,6 +1,8 @@ find_package(glfw3 QUIET) +list(APPEND vkcv_definitions GLFW_INCLUDE_VULKAN) + if (glfw3_FOUND) list(APPEND vkcv_libraries glfw) diff --git a/modules/asset_loader/CMakeLists.txt b/modules/asset_loader/CMakeLists.txt index d2a9b817ea68c7851fd2123f76b378d8a4d85ac0..c5a1fd0eb9620d3a95af1c52a9e7456337047c7b 100644 --- a/modules/asset_loader/CMakeLists.txt +++ b/modules/asset_loader/CMakeLists.txt @@ -38,3 +38,5 @@ target_include_directories(vkcv_asset_loader SYSTEM BEFORE PRIVATE ${vkcv_asset_ # add the own include directory for public headers target_include_directories(vkcv_asset_loader BEFORE PUBLIC ${vkcv_asset_loader_include}) + +target_compile_definitions(vkcv_asset_loader PUBLIC ${vkcv_asset_loader_definitions}) diff --git a/modules/asset_loader/config/STB.cmake b/modules/asset_loader/config/STB.cmake index da20d3ec07f98c865b4c6e38518f668b226cbfb9..1287d0a9ddda559e061ddd680bc815e24b3e2075 100644 --- a/modules/asset_loader/config/STB.cmake +++ b/modules/asset_loader/config/STB.cmake @@ -1,6 +1,10 @@ if (EXISTS "${vkcv_asset_loader_lib_path}/stb") list(APPEND vkcv_asset_loader_includes ${vkcv_asset_loader_lib}/stb) + + list(APPEND vkcv_asset_loader_definitions STB_IMAGE_IMPLEMENTATION) + list(APPEND vkcv_asset_loader_definitions STBI_ONLY_JPEG) + list(APPEND vkcv_asset_loader_definitions STBI_ONLY_PNG) else() message(WARNING "STB is required..! Update the submodules!") endif () diff --git a/modules/asset_loader/src/vkcv/asset/asset_loader.cpp b/modules/asset_loader/src/vkcv/asset/asset_loader.cpp index 97fd39515290ac9235b3936d44d3e40a584ef84f..c21d0c9f70bc81561e1078b15b8372e6dd4730f5 100644 --- a/modules/asset_loader/src/vkcv/asset/asset_loader.cpp +++ b/modules/asset_loader/src/vkcv/asset/asset_loader.cpp @@ -3,9 +3,6 @@ #include <string.h> // memcpy(3) #include <stdlib.h> // calloc(3) #include <fx/gltf.h> -#define STB_IMAGE_IMPLEMENTATION -#define STBI_ONLY_JPEG -#define STBI_ONLY_PNG #include <stb_image.h> #include <vkcv/Logger.hpp> #include <algorithm> diff --git a/modules/camera/config/GLM.cmake b/modules/camera/config/GLM.cmake index ecf3a190e24d7bd9d6ce764a070a0d3c8424e9cf..6f6e0f65e3025a635855f8563280bfb8c420f475 100644 --- a/modules/camera/config/GLM.cmake +++ b/modules/camera/config/GLM.cmake @@ -10,8 +10,8 @@ else() list(APPEND vkcv_camera_libraries glm) - list(APPEND vkcv_camera_defines GLM_DEPTH_ZERO_TO_ONE=1) - list(APPEND vkcv_camera_defines GLM_FORCE_LEFT_HANDED=1) + list(APPEND vkcv_camera_defines GLM_DEPTH_ZERO_TO_ONE) + list(APPEND vkcv_camera_defines GLM_FORCE_LEFT_HANDED) else() message(WARNING "GLM is required..! Update the submodules!") endif () diff --git a/src/vkcv/Swapchain.cpp b/src/vkcv/Swapchain.cpp index 33714adac7cec7c1b5e0013387424c4f865454ab..2c5b3530c396bc3532aa94cb59a120e3555291bf 100644 --- a/src/vkcv/Swapchain.cpp +++ b/src/vkcv/Swapchain.cpp @@ -1,7 +1,6 @@ #include <vkcv/Swapchain.hpp> #include <utility> -#define GLFW_INCLUDE_VULKAN #include <GLFW/glfw3.h> namespace vkcv