From a3001decc976bcac08baf197cd359fae242e880d Mon Sep 17 00:00:00 2001
From: Alexander Gauggel <agauggel@uni-koblenz.de>
Date: Wed, 23 Jun 2021 16:41:46 +0200
Subject: [PATCH] [#82] Add missing abs in shader
---
projects/voxelization/resources/shaders/shader.frag | 2 +-
.../voxelization/resources/shaders/voxelSecondaryBounce.comp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/projects/voxelization/resources/shaders/shader.frag b/projects/voxelization/resources/shaders/shader.frag
index a5793542..e8f85919 100644
--- a/projects/voxelization/resources/shaders/shader.frag
+++ b/projects/voxelization/resources/shaders/shader.frag
@@ -91,7 +91,7 @@ void main() {
vec3 F_out = fresnelSchlick(NoV, f0);
vec3 diffuse = lambertBRDF(albedo) * (1 - F_in) * (1 - F_out);
- vec3 up = N_geo.y >= 0.99 ? vec3(1, 0, 0) : vec3(0, 1, 0);
+ vec3 up = abs(N_geo.y) >= 0.99 ? vec3(1, 0, 0) : vec3(0, 1, 0);
vec3 right = normalize(cross(up, N));
up = cross(N, right);
mat3 toSurface = mat3(right, up, N);
diff --git a/projects/voxelization/resources/shaders/voxelSecondaryBounce.comp b/projects/voxelization/resources/shaders/voxelSecondaryBounce.comp
index 3e10ecb8..29026e70 100644
--- a/projects/voxelization/resources/shaders/voxelSecondaryBounce.comp
+++ b/projects/voxelization/resources/shaders/voxelSecondaryBounce.comp
@@ -32,7 +32,7 @@ void main(){
float halfVoxelSize = voxelInfo.extent / float(voxelImageSize.x) * 0.5f;
vec3 pos = voxelCoordinatesToWorldPosition(UV, voxelImageSize.x, voxelInfo, halfVoxelSize);
- vec3 up = N.y >= 0.99 ? vec3(1, 0, 0) : vec3(0, 1, 0);
+ vec3 up = abs(N.y) >= 0.99 ? vec3(1, 0, 0) : vec3(0, 1, 0);
vec3 right = normalize(cross(up, N));
up = cross(N, right);
mat3 toSurface = mat3(right, up, N);
--
GitLab