From b518eb83c84a2442d5462436f233bf8233b0b294 Mon Sep 17 00:00:00 2001
From: Trevor Hollmann <thollmann@uni-koblenz.de>
Date: Sat, 17 Jul 2021 14:18:58 +0200
Subject: [PATCH] [#79] Move FIXME/TODO comments to gitlab issue.
---
modules/asset_loader/src/vkcv/asset/asset_loader.cpp | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/modules/asset_loader/src/vkcv/asset/asset_loader.cpp b/modules/asset_loader/src/vkcv/asset/asset_loader.cpp
index e68d9e26..a3651d6b 100644
--- a/modules/asset_loader/src/vkcv/asset/asset_loader.cpp
+++ b/modules/asset_loader/src/vkcv/asset/asset_loader.cpp
@@ -121,7 +121,7 @@ int createTextures(const std::vector<fx::gltf::Texture>& tex_src,
return ASSET_ERROR;
}
}
- c = 4; // FIXME hardcoded to always have RGBA channel layout
+ c = 4;
const size_t nbytes = w * h * c;
std::vector<uint8_t> imgdata;
imgdata.resize(nbytes);
@@ -448,7 +448,6 @@ int createVertexGroups(fx::gltf::Mesh const& objectMesh,
}
const uint32_t relevantBufferSize = relevantBufferEnd - relevantBufferOffset;
- // FIXME: This only works when all vertex attributes are in one buffer
std::vector<uint8_t> vertexBufferData;
if (!probe) {
vertexBufferData.resize(relevantBufferSize);
@@ -748,9 +747,6 @@ int probeScene(const std::filesystem::path& path, Scene& scene) {
}
-// TODO Do we want to _extend_ the given scene with the newly loaded mesh or do
-// we want to _clear_ the scene such that the result will always be an empty
-// scene with only the given mesh (and associated textures etc)?
int loadMesh(const std::filesystem::path &path, const std::string &name, Scene &scene) {
fx::gltf::Document sceneObjects;
--
GitLab