From c9cdc047bea5f7662291c9e595910461d6a19830 Mon Sep 17 00:00:00 2001
From: Trevor Hollmann <thollmann@uni-koblenz.de>
Date: Fri, 25 Jun 2021 10:03:15 +0200
Subject: [PATCH] [#79] Add more TODO comments to loadScene function.
---
modules/asset_loader/src/vkcv/asset/asset_loader.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/modules/asset_loader/src/vkcv/asset/asset_loader.cpp b/modules/asset_loader/src/vkcv/asset/asset_loader.cpp
index 7da34745..a1fb2220 100644
--- a/modules/asset_loader/src/vkcv/asset/asset_loader.cpp
+++ b/modules/asset_loader/src/vkcv/asset/asset_loader.cpp
@@ -298,6 +298,7 @@ int loadScene(const std::string &path, Scene &scene){
recurseExceptionPrint(e, path);
return ASSET_ERROR;
}
+ // TODO use std::filesystem::path instead of std::string for path/uri?
size_t pos = path.find_last_of("/");
auto dir = path.substr(0, pos);
@@ -309,6 +310,8 @@ int loadScene(const std::string &path, Scene &scene){
// which is only needed to get the vertex buffer for that mesh... none of
// this is a good solution.
fx::gltf::Accessor posAccessor;
+ // TODO vertexAttributes are per-VertexGroup and should not be in the top
+ // most scope of this function next to arrays stored per-Scene...
std::vector<VertexAttribute> vertexAttributes;
std::vector<Material> materials;
std::vector<Texture> textures;
--
GitLab