From d88e19e986254cc92579d3b0f312c93a44847d92 Mon Sep 17 00:00:00 2001
From: Mark Oliver Mints <mmints@uni-koblenz.de>
Date: Tue, 10 Aug 2021 06:33:46 +0200
Subject: [PATCH] [#71] add todo's
---
src/vkcv/PipelineManager.cpp | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/vkcv/PipelineManager.cpp b/src/vkcv/PipelineManager.cpp
index 29c7cbde..222cdb7c 100644
--- a/src/vkcv/PipelineManager.cpp
+++ b/src/vkcv/PipelineManager.cpp
@@ -417,9 +417,12 @@ namespace vkcv
return PipelineHandle(id, [&](uint64_t id) { destroyPipelineById(id); });
}
+ // TODO: Refactor compute pipeline creation
PipelineHandle PipelineManager::createComputePipeline(
const ShaderProgram &shaderProgram,
const std::vector<vk::DescriptorSetLayout> &descriptorSetLayouts) {
+ // TODO: The creation function should be implemented in the same manner as the graphics pipeline.
+ // TODO: Implement a Config Struct that contains all necessary parameters and hand it over to the create function.
// Temporally handing over the Shader Program instead of a pipeline config
vk::ShaderModule computeModule{};
@@ -471,7 +474,7 @@ namespace vkcv
// There is an issue for refactoring the Pipeline Manager.
// While including Compute Pipeline Creation, some private helper functions where introduced:
-
+ // TODO: Use this function instead of the the m_Device function or delete it
vk::Result PipelineManager::createShaderModule(vk::ShaderModule &module, const ShaderProgram &shaderProgram, const ShaderStage stage)
{
std::vector<char> code = shaderProgram.getShader(stage).shaderCode;
--
GitLab