Small fix for next verifiers

dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/AbstractVerifier.java

@@ -18,7 +18,7 @@ public abstract class AbstractVerifier implements Verifier {
   protected VerificationType verificationType;
   protected AbstractDmnVerifierConfig verifierConfig;
   protected VerifierResult.Builder resultBuilder;
-  protected VerificationResultEntryFactory vref;
+  protected VerificationResultEntryFactory vreFactory;
   protected DmnObjectContainer dmnObjectContainer;
 
   public VerificationType getVerificationType() {
@@ -41,15 +41,11 @@ public abstract class AbstractVerifier implements Verifier {
                   .verifierType()
                   .getMethod("getInstance")
                   .invoke(null, null);
-    } catch (IllegalAccessException e) {
-      e.printStackTrace();
-    } catch (NoSuchMethodException e) {
-      e.printStackTrace();
-    } catch (InvocationTargetException e) {
+    } catch (IllegalAccessException | NoSuchMethodException | InvocationTargetException e) {
       e.printStackTrace();
     }
     resultBuilder = VerifierResult.getBuilder().fromVerifier(this);
-    vref = VerificationResultEntryFactory.create(resultBuilder);
+    vreFactory = VerificationResultEntryFactory.create(resultBuilder);
   }
 
   public final Future<VerifierResult> verify(ExecutorService executor) {

dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/DateVerifier.java

@@ -57,8 +57,8 @@ public class DateVerifier extends AbstractVerifier {
     // 1. check pattern
     Matcher matcher = datePattern.matcher(dateStringValue);
     if (!matcher.find()) {
-      vref.addElement(VerificationResultEntryElement.create(dateValue));
-      vref.addToEntry(
+      vreFactory.addElement(VerificationResultEntryElement.create(dateValue));
+      vreFactory.addToEntry(
           VerificationClassification.FATAL_ERROR,
           "Date value '%s' does not match 'date and time(\"yyyy-mm-ddTHH:MM:SS\").'",
           dateStringValue);
@@ -68,8 +68,8 @@ public class DateVerifier extends AbstractVerifier {
       try {
         LocalDateTime.parse(dateTime);
       } catch (DateTimeParseException e) {
-        vref.addElement(VerificationResultEntryElement.create(dateValue));
-        vref.addToEntry(
+        vreFactory.addElement(VerificationResultEntryElement.create(dateValue));
+        vreFactory.addToEntry(
             VerificationClassification.FATAL_ERROR, "Date value '%s' is no valid date.", dateTime);
       }
     }

dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/EmptyOutputVerifier.java

@@ -31,8 +31,8 @@ public class EmptyOutputVerifier extends AbstractVerifier {
 
   private void checkEmptyOutputValue(VDmnOutputValue outputValue) {
     if (outputValue.getText().isEmpty()) {
-      vref.addElement(VerificationResultEntryElement.create(outputValue));
-      vref.addToEntry(VerificationClassification.WARNING, "Output value is empty.'");
+      vreFactory.addElement(VerificationResultEntryElement.create(outputValue));
+      vreFactory.addToEntry(VerificationClassification.WARNING, "Output value is empty.'");
     }
   }
 }

dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/EquivalentVerifier.java

@@ -68,9 +68,9 @@ public class EquivalentVerifier extends AbstractVerifier {
     for (int i = 0; i < stringVals.size(); i++) {
       for (int u = 0; u < stringValsInner.size(); u++) {
         if (wordnetService.areNounsSynonyms(stringVals.get(i), stringValsInner.get(u))) {
-          vref.addElement(VerificationResultEntryElement.create(v1));
-          vref.addElement(VerificationResultEntryElement.create(v2));
-          vref.addToEntry(
+          vreFactory.addElement(VerificationResultEntryElement.create(v1));
+          vreFactory.addElement(VerificationResultEntryElement.create(v2));
+          vreFactory.addToEntry(
               VerificationClassification.WARNING,
               "String values %s and %s might be equivalent.",
               stringVals.get(i),

dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/IdenticalVerifier.java

@@ -45,10 +45,10 @@ public class IdenticalVerifier extends AbstractVerifier {
     if (i == inputs.size()) {
       currentRules.forEach(
           rule ->
-              vref.addElement(
+              vreFactory.addElement(
                   VerificationResultEntryElement.create(dmnDecisionTable)
                       .withIdentifier(rule.getRuleId())));
-      vref.addToEntry(VerificationClassification.WARNING, "identical");
+      vreFactory.addToEntry(VerificationClassification.WARNING, "identical");
     } else {
       List<VDmnInputValue> curInVals = new ArrayList<>();
       List<VDmnInputValue> sortInVals =

dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/InputValueSyntaxVerifier.java

@@ -29,8 +29,8 @@ public class InputValueSyntaxVerifier extends AbstractVerifier {
     // no Date, because of extra DateVerifier
     if (inputValue.getDmnColumn().getTypeRef() != VTypeRef.DATE
         && inputValue.getBoundary() instanceof InvalidBoundary) {
-      vref.addElement(VerificationResultEntryElement.create(inputValue));
-      vref.addToEntry(
+      vreFactory.addElement(VerificationResultEntryElement.create(inputValue));
+      vreFactory.addToEntry(
           VerificationClassification.FATAL_ERROR,
           "Input value is not valid: " + inputValue.getText());
       System.out.println(inputValue.getText() + " IS INVALID SYNTAX");

dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/OverlappingVerifier.java

@@ -58,10 +58,10 @@ public class OverlappingVerifier extends AbstractVerifier {
         // TODO
         currentRuleIds.forEach(
             rule ->
-                vref.addElement(
+                vreFactory.addElement(
                     VerificationResultEntryElement.create(inColumns.get(0).getDmnDecisionTable())
                         .withIdentifier(rule.getRuleId())));
-        vref.addToEntry(VerificationClassification.WARNING, "overlapping");
+        vreFactory.addToEntry(VerificationClassification.WARNING, "overlapping");
       }
     } else {
       // check current column

dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/SubsumptionVerifier.java

@@ -54,10 +54,10 @@ public class SubsumptionVerifier extends AbstractVerifier {
         // TODO
         currentRuleIds.forEach(
             rule ->
-                vref.addElement(
+                vreFactory.addElement(
                     VerificationResultEntryElement.create(inColumns.get(0).getDmnDecisionTable())
                         .withIdentifier(rule.getRuleId())));
-        vref.addToEntry(VerificationClassification.WARNING, "subsumption");
+        vreFactory.addToEntry(VerificationClassification.WARNING, "subsumption");
       }
     } else {
       // get all input values from the current column, and filter with the prev. iteration