Skip to content
Snippets Groups Projects
Commit 790a330f authored by Jonas Blatt's avatar Jonas Blatt :ant:
Browse files

Merge branch 'bug/missingrules' into 'develop'

bugfix missing Rules, (TODO ID was not unique)

See merge request jonasblatt/ma-jonasblatt-dmn-verifier!34
parents a35f16aa 5132096f
No related branches found
No related tags found
No related merge requests found
...@@ -2,6 +2,7 @@ package de.unikoblenz.fgbks.core.dmn.verification.verifier.impl; ...@@ -2,6 +2,7 @@ package de.unikoblenz.fgbks.core.dmn.verification.verifier.impl;
import static de.unikoblenz.fgbks.core.dmn.domain.vdmn.utils.VDmnFunctions.templateDecision; import static de.unikoblenz.fgbks.core.dmn.domain.vdmn.utils.VDmnFunctions.templateDecision;
import de.unikoblenz.fgbks.base.utils.UniqueIdGenerator;
import de.unikoblenz.fgbks.base.utils.boundary.Boundary; import de.unikoblenz.fgbks.base.utils.boundary.Boundary;
import de.unikoblenz.fgbks.base.utils.boundary.bicreater.BoundaryBiCreaterType; import de.unikoblenz.fgbks.base.utils.boundary.bicreater.BoundaryBiCreaterType;
import de.unikoblenz.fgbks.base.utils.boundary.checker.BoundaryCheckType; import de.unikoblenz.fgbks.base.utils.boundary.checker.BoundaryCheckType;
...@@ -155,7 +156,8 @@ public class MissingRuleVerifier extends AbstractVerifier { ...@@ -155,7 +156,8 @@ public class MissingRuleVerifier extends AbstractVerifier {
missingRule.setInputValue( missingRule.setInputValue(
i - 1, i - 1,
VDmnInputValueImpl.getBuilder() VDmnInputValueImpl.getBuilder()
.withInputEntryId(new InputEntryId("TODO")) // TODO .withInputEntryId(
new InputEntryId("Entry_" + Long.toString(UniqueIdGenerator.getNextId(), 16)))
.withText("") .withText("")
.withDmnInputColumn((VDmnInputColumn) missingRuleValue.getDmnColumn()) .withDmnInputColumn((VDmnInputColumn) missingRuleValue.getDmnColumn())
.withDmnRule(missingRule) .withDmnRule(missingRule)
...@@ -201,7 +203,7 @@ public class MissingRuleVerifier extends AbstractVerifier { ...@@ -201,7 +203,7 @@ public class MissingRuleVerifier extends AbstractVerifier {
Builder b = Builder b =
VDmnRuleImpl.getBuilder() VDmnRuleImpl.getBuilder()
.withRuleId(new RuleId("TODO")) // TODO .withRuleId(new RuleId("Rule_" + Long.toString(UniqueIdGenerator.getNextId(), 16)))
.withDmnDecisionTable(inputs.get(0).getDmnDecisionTable()) .withDmnDecisionTable(inputs.get(0).getDmnDecisionTable())
.withRowNumber(new RowNumber(INITIAL_ROW_NUMER)); .withRowNumber(new RowNumber(INITIAL_ROW_NUMER));
for (VDmnInputValue inputValue : missingRuleValues) { for (VDmnInputValue inputValue : missingRuleValues) {
...@@ -214,7 +216,8 @@ public class MissingRuleVerifier extends AbstractVerifier { ...@@ -214,7 +216,8 @@ public class MissingRuleVerifier extends AbstractVerifier {
copy.setInputValue( copy.setInputValue(
x, x,
VDmnInputValueImpl.getBuilder() VDmnInputValueImpl.getBuilder()
.withInputEntryId(new InputEntryId("TODO")) // TODO .withInputEntryId(
new InputEntryId("Entry_" + Long.toString(UniqueIdGenerator.getNextId(), 16)))
.withText("") .withText("")
.withDmnRule(copy) .withDmnRule(copy)
.withBoundary(x == i ? bi.get() : missingRuleValues.get(x).getBoundary()) .withBoundary(x == i ? bi.get() : missingRuleValues.get(x).getBoundary())
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment