#9 Action for new output column in Missing Input Data Verifier

dmnverifierapi/src/main/java/de/unikoblenz/fgbks/core/dmn/verification/verifier/impl/MissingInputDataVerifier.java

@@ -72,7 +72,7 @@ public class MissingInputDataVerifier extends AbstractVerifier {
       vreFactory
           .addVerificationFix(
               VerificationFix.getBuilder()
-                  .withFixName(new Name("Add new Data Input"))
+                  .withFixName(new Name("New Data Input"))
                   .addAction(
                       Action.getBuilder()
                           .withActionType(ActionType.CREATE)
@@ -96,7 +96,9 @@ public class MissingInputDataVerifier extends AbstractVerifier {
       // Actions for connecting to existing input Data
       searchPossibleInputData(inputColumn);
       // Actions for connection to existing decisions
-      searchPossibleInputDecissions(inputColumn);
+      searchPossibleInputDecisions(inputColumn);
+      // Actions for creating output columns in connected decisions
+      searchPossibleConnectedDecisions(inputColumn);
     }
     // Add to result
     vreFactory.addToEntry(
@@ -125,7 +127,7 @@ public class MissingInputDataVerifier extends AbstractVerifier {
     }
   }
 
-  private void searchPossibleInputDecissions(VDmnInputColumn inputColumn) {
+  private void searchPossibleInputDecisions(VDmnInputColumn inputColumn) {
     for (VDmnDecision decision : dmnObjectContainer.getVDmnDefinition().getVDmnDecisions()) {
       for (VDmnOutputColumn outputColumn :
           decision.getVDmnDecisionTable().getVDmnOutputColumns().stream()
@@ -157,4 +159,24 @@ public class MissingInputDataVerifier extends AbstractVerifier {
       }
     }
   }
+
+  private void searchPossibleConnectedDecisions(VDmnInputColumn inputColumn) {
+    for (VDmnNode node : inputColumn.getVDmnDecision().getVDmnInformationRequirements()) {
+      if (node.isDecision()) {
+        VDmnDecision decision = (VDmnDecision) node;
+        vreFactory.addVerificationFix(
+            VerificationFix.getBuilder()
+                .withFixName("New Output Column in decision " + getDecisionStringName(decision))
+                .addAction(
+                    Action.getBuilder()
+                        .withActionType(ActionType.CREATE)
+                        .withActionScope(ActionScope.OUTPUT_COLUMN)
+                        .addIdValue(decision.getDecisionId())
+                        .addValue("name", inputColumn.getName().get().getValue())
+                        .addValue("typeRef", inputColumn.getTypeRef().getName())
+                        .build())
+                .build());
+      }
+    }
+  }
 }

dmnverifierfrontend/src/main/resources/META-INF/resources/js/dmnVerifierActions.js

@@ -192,11 +192,13 @@ function performVerificationFixCREATE(verificationEntry, fixAction) {
       createInputData(verificationEntry, fixAction);
       break;
     case 'INPUT_COLUMN':
-      createInputColumn(verificationEntry, fixAction);
+      createColumn(verificationEntry, fixAction, 'dmn:InputClause');
+      break;
+    case 'OUTPUT_COLUMN':
+      createColumn(verificationEntry, fixAction, 'dmn:OutputClause');
       break;
     case 'INPUT_ENTRY':
     case 'OUTPUT_ENTRY':
-    case 'OUTPUT_COLUMN':
     case 'DECISION':
     default:
       alert("ACTION undefined: " + fixAction.actionType + ' -> '
@@ -247,13 +249,19 @@ function createInputData(verificationEntry, fixAction) {
  *
  * @param {VerificationEntry}  verificationEntry
  * @param {Action} fixAction
+ * @param {String} colType
  */
-function createInputColumn(verificationEntry, fixAction) {
+function createColumn(verificationEntry, fixAction, colType) {
   openViewWithId(fixAction.actionValues['decisionId']);
   const modeler = getCurrentModeler();
-  let col = modeler.addCol({type: 'dmn:InputClause'});
-  col.businessObject.inputExpression.typeRef = fixAction.actionValues['typeRef'].toLowerCase();
-  col.businessObject.inputExpression.text = fixAction.actionValues['name'];
+  let col = modeler.addCol({type: colType});
+  if (colType === 'dmn:InputClause') {
+    col.businessObject.inputExpression.typeRef = fixAction.actionValues['typeRef'].toLowerCase();
+    col.businessObject.inputExpression.text = fixAction.actionValues['name'];
+  } else {
+    col.businessObject.typeRef = fixAction.actionValues['typeRef'].toLowerCase();
+    col.businessObject.name = fixAction.actionValues['name'];
+  }
   openViewWithId(fixAction.actionValues['decisionId']);
 }