[#35] fix fov (converting to radians)

modules/camera/include/vkcv/camera/Camera.hpp

@@ -25,6 +25,10 @@ namespace vkcv {
         float m_pitch;
         float m_yaw;
 
+        int m_fov_nsteps;
+        float m_fov_min;
+        float m_fov_max;
+
         bool m_forward;
         bool m_backward;
         bool m_left;
@@ -56,6 +60,8 @@ namespace vkcv {
         float getFov() const;
 
         void setFov(float fov);
+        
+        void changeFov(double fov);
 
         void updateRatio(float ratio);
 

modules/camera/src/vkcv/camera/Camera.cpp

@@ -11,6 +11,10 @@ namespace vkcv {
         m_pitch = 0.0;
         m_yaw = 180.0;
 
+        m_fov_nsteps = 100;
+        m_fov_min = 10;
+        m_fov_max = 120;
+
         m_forward = false;
         m_backward = false;
         m_left = false;
@@ -64,6 +68,20 @@ namespace vkcv {
         setPerspective( m_fov, m_ratio, m_near, m_far);
     }
 
+    void Camera::changeFov(double offset){
+        float fov = m_fov;
+        float fov_range = m_fov_max - m_fov_min;
+        float fov_stepsize = glm::radians(fov_range)/m_fov_nsteps;
+        fov -= (float) offset*fov_stepsize;
+        if (fov < glm::radians(m_fov_min)) {
+            fov = glm::radians(m_fov_min);
+        }
+        if (fov > glm::radians(m_fov_max)) {
+            fov = glm::radians(m_fov_max);
+        }
+        setFov(fov);
+    }
+
     void Camera::updateRatio( float ratio){
         m_ratio = ratio;
         setPerspective( m_fov, m_ratio, m_near, m_far);

modules/camera/src/vkcv/camera/CameraManager.cpp

@@ -50,16 +50,7 @@ namespace vkcv{
     }
 
     void CameraManager::scrollCallback(double offsetX, double offsetY) {
-
-        float fov = m_camera.getFov();
-        fov -= (float) offsetY;
-        if (fov < 1.0f) {
-            fov = 1.0f;
-        }
-        if (fov > 45.0f) {
-            fov = 45.0f;
-        }
-        m_camera.setFov(fov);
+        m_camera.changeFov(offsetY);
     }
 
     void CameraManager::keyCallback(int key, int scancode, int action, int mods) {