Skip to content
Snippets Groups Projects
Commit c9cdc047 authored by Trevor Hollmann's avatar Trevor Hollmann
Browse files

[#79] Add more TODO comments to loadScene function.

parent 46228e1c
No related branches found
No related tags found
1 merge request!69Resolve "Rework Asset Loader API"
Pipeline #26021 passed
...@@ -298,6 +298,7 @@ int loadScene(const std::string &path, Scene &scene){ ...@@ -298,6 +298,7 @@ int loadScene(const std::string &path, Scene &scene){
recurseExceptionPrint(e, path); recurseExceptionPrint(e, path);
return ASSET_ERROR; return ASSET_ERROR;
} }
// TODO use std::filesystem::path instead of std::string for path/uri?
size_t pos = path.find_last_of("/"); size_t pos = path.find_last_of("/");
auto dir = path.substr(0, pos); auto dir = path.substr(0, pos);
...@@ -309,6 +310,8 @@ int loadScene(const std::string &path, Scene &scene){ ...@@ -309,6 +310,8 @@ int loadScene(const std::string &path, Scene &scene){
// which is only needed to get the vertex buffer for that mesh... none of // which is only needed to get the vertex buffer for that mesh... none of
// this is a good solution. // this is a good solution.
fx::gltf::Accessor posAccessor; fx::gltf::Accessor posAccessor;
// TODO vertexAttributes are per-VertexGroup and should not be in the top
// most scope of this function next to arrays stored per-Scene...
std::vector<VertexAttribute> vertexAttributes; std::vector<VertexAttribute> vertexAttributes;
std::vector<Material> materials; std::vector<Material> materials;
std::vector<Texture> textures; std::vector<Texture> textures;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment