Skip to content
Snippets Groups Projects
Commit 19a8184a authored by Jonas Blatt's avatar Jonas Blatt :ant:
Browse files

Fix PartialReductionVerifier

parent d5299874
No related branches found
No related tags found
No related merge requests found
......@@ -161,11 +161,11 @@ public class VDmnFunctions {
return true;
}
for (int i = 0; i < oneRule.getDmnOutputValues().size(); i++) {
if (oneRule
if (!oneRule
.getDmnOutputValues()
.get(i)
.getText()
.equals(otherRule.getDmnOutputValues().get(0).getText())) {
.equals(otherRule.getDmnOutputValues().get(i).getText())) {
return true;
}
}
......
......@@ -32,8 +32,7 @@ public class PartialReductionVerifier extends AbstractVerifier {
List<List<VDmnRule>> identicalOutputCluster =
VDmnFunctions.getRuleClustersWithIdenticalOutput(dmnDecisionTable);
List<VDmnInputColumn> inColumns = dmnDecisionTable.getInputColumns();
identicalOutputCluster.stream() // do: parallelStream() ?
.forEach(c -> findPartialReduction(inColumns, 0, c, false));
identicalOutputCluster.forEach(c -> findPartialReduction(inColumns, 0, c, false));
}
private void findPartialReduction(
......@@ -46,7 +45,7 @@ public class PartialReductionVerifier extends AbstractVerifier {
VerificationResultEntryElement.create(inColumns.get(0).getDmnDecisionTable())
.withIdentifier(rule.getRuleId())));
vreFactory.addVerificationFix(SHOW_RULES);
vreFactory.addToEntry(VerificationClassification.WARNING, "PartialReduction");
vreFactory.addToEntry(VerificationClassification.INFO, "PartialReduction");
}
} else {
List<VDmnInputValue> rules =
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment