Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
VkCV Framework
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Monitor
Service Desk
Analyze
Contributor analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Vulkan2021
VkCV Framework
Commits
d88e19e9
Commit
d88e19e9
authored
3 years ago
by
Mark Oliver Mints
Browse files
Options
Downloads
Patches
Plain Diff
[
#71
] add todo's
parent
ad066d60
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!83
Resolve "Refactor Pipeline Config and Manager"
Pipeline
#26676
passed
3 years ago
Stage: build
Stage: deploy
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/vkcv/PipelineManager.cpp
+4
-1
4 additions, 1 deletion
src/vkcv/PipelineManager.cpp
with
4 additions
and
1 deletion
src/vkcv/PipelineManager.cpp
+
4
−
1
View file @
d88e19e9
...
...
@@ -417,9 +417,12 @@ namespace vkcv
return
PipelineHandle
(
id
,
[
&
](
uint64_t
id
)
{
destroyPipelineById
(
id
);
});
}
// TODO: Refactor compute pipeline creation
PipelineHandle
PipelineManager
::
createComputePipeline
(
const
ShaderProgram
&
shaderProgram
,
const
std
::
vector
<
vk
::
DescriptorSetLayout
>
&
descriptorSetLayouts
)
{
// TODO: The creation function should be implemented in the same manner as the graphics pipeline.
// TODO: Implement a Config Struct that contains all necessary parameters and hand it over to the create function.
// Temporally handing over the Shader Program instead of a pipeline config
vk
::
ShaderModule
computeModule
{};
...
...
@@ -471,7 +474,7 @@ namespace vkcv
// There is an issue for refactoring the Pipeline Manager.
// While including Compute Pipeline Creation, some private helper functions where introduced:
// TODO: Use this function instead of the the m_Device function or delete it
vk
::
Result
PipelineManager
::
createShaderModule
(
vk
::
ShaderModule
&
module
,
const
ShaderProgram
&
shaderProgram
,
const
ShaderStage
stage
)
{
std
::
vector
<
char
>
code
=
shaderProgram
.
getShader
(
stage
).
shaderCode
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment