Skip to content
Snippets Groups Projects
Commit d88e19e9 authored by Mark Oliver Mints's avatar Mark Oliver Mints
Browse files

[#71] add todo's

parent ad066d60
Branches
Tags
1 merge request!83Resolve "Refactor Pipeline Config and Manager"
Pipeline #26676 passed
...@@ -417,9 +417,12 @@ namespace vkcv ...@@ -417,9 +417,12 @@ namespace vkcv
return PipelineHandle(id, [&](uint64_t id) { destroyPipelineById(id); }); return PipelineHandle(id, [&](uint64_t id) { destroyPipelineById(id); });
} }
// TODO: Refactor compute pipeline creation
PipelineHandle PipelineManager::createComputePipeline( PipelineHandle PipelineManager::createComputePipeline(
const ShaderProgram &shaderProgram, const ShaderProgram &shaderProgram,
const std::vector<vk::DescriptorSetLayout> &descriptorSetLayouts) { const std::vector<vk::DescriptorSetLayout> &descriptorSetLayouts) {
// TODO: The creation function should be implemented in the same manner as the graphics pipeline.
// TODO: Implement a Config Struct that contains all necessary parameters and hand it over to the create function.
// Temporally handing over the Shader Program instead of a pipeline config // Temporally handing over the Shader Program instead of a pipeline config
vk::ShaderModule computeModule{}; vk::ShaderModule computeModule{};
...@@ -471,7 +474,7 @@ namespace vkcv ...@@ -471,7 +474,7 @@ namespace vkcv
// There is an issue for refactoring the Pipeline Manager. // There is an issue for refactoring the Pipeline Manager.
// While including Compute Pipeline Creation, some private helper functions where introduced: // While including Compute Pipeline Creation, some private helper functions where introduced:
// TODO: Use this function instead of the the m_Device function or delete it
vk::Result PipelineManager::createShaderModule(vk::ShaderModule &module, const ShaderProgram &shaderProgram, const ShaderStage stage) vk::Result PipelineManager::createShaderModule(vk::ShaderModule &module, const ShaderProgram &shaderProgram, const ShaderStage stage)
{ {
std::vector<char> code = shaderProgram.getShader(stage).shaderCode; std::vector<char> code = shaderProgram.getShader(stage).shaderCode;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment